Skip to content

client: updating keyspace group must check the previous version #9862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

client: updating keyspace group must check the previous version #9862

wants to merge 8 commits into from
+5,251 −75

Conversation

@bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Oct 22, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #6770

kv proto: #1361

What is changed and how does it work?

'FindGroupByKeyspaceID' must carry the current keyspace group version, and the server needs to check the memory
state isn't stale, and then return the server keyspace group info.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 22, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Oct 22, 2025
@bufferflies bufferflies force-pushed the keyspace/version branch 2 times, most recently from 2f5525f to 1460ce5 Compare October 23, 2025 01:17
@bufferflies
request with version
3f7b9ee 
Signed-off-by: 童剑 <[email protected]>
@bufferflies bufferflies marked this pull request as ready for review October 23, 2025 04:31
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2025
@bufferflies bufferflies changed the title client: keyspace group update must check the version avoid the stale update client: updating keyspace group must check the previous version Oct 23, 2025
ystaticy
ystaticy reviewed Nov 6, 2025
View reviewed changes
client/servicediscovery/tso_service_discovery.go
// urls are the primary/secondary serving URL
urls []string

// version is used to avoid updating stale info
Copy link
Contributor

@ystaticy ystaticy Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a comment to clarify where the version is sourced from and briefly explain its usage?

Copy link
Contributor Author

@bufferflies bufferflies Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ystaticy
ystaticy reviewed Nov 6, 2025
View reviewed changes
client/servicediscovery/tso_service_discovery.go
primaryURL: "",
secondaryURLs: make([]string, 0),
urls: make([]string, 0),
version: 0,
Copy link
Contributor

@ystaticy ystaticy Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the TSO client starts up, does it use version=0 for the initial request?

Furthermore, if this initial request is routed to a TSO service with a lower version, is that behavior expected?

Copy link
Contributor Author

@bufferflies bufferflies Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this version just works for requesting the keyspace group. Most updates don't relate to this client's keyspace ID, so it doesn't need to be updated.

Copy link
Contributor Author

@bufferflies bufferflies Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The higher version of the server side doesn't mean that the client's keyspace group has changed.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 11, 2025

@bufferflies: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-next-gen 07950e5 link true /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmPotato JmPotato Awaiting requested review from JmPotato

@rleungx rleungx Awaiting requested review from rleungx

1 more reviewer

@ystaticy ystaticy ystaticy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Round-robin updateMember may cause the timestamp to fallback

2 participants

@bufferflies @ystaticy